vm_introspect: fix build breaker and warning #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
force-pushed
the
patch-axel-6
branch
2 times, most recently
from
f99d07d
to
65ba083
Compare
|
Making this a draft, as I'd like to see CI build this, but it does not. I'd expect this to build |
axel-h
force-pushed
the
patch-axel-6
branch
2 times, most recently
from
82fce95
to
86d07b3
Compare
Signed-off-by: Axel Heider <[email protected]>
axel-h
force-pushed
the
patch-axel-6
branch
2 times, most recently
from
1617873
to
82ad8f4
Compare
Signed-off-by: Axel Heider <[email protected]>
axel-h
changed the title
|
I've fixed the build errors and warning now, and it seems to pass in CI also. Any feedback here if this works now as expected and we could merge this to have the example working again? Then I drop the commit on top, as this is just a hack to get the CI run. |
|
I've dropped the CI test commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes from seL4/camkes-vm#48 and seL4/camkes-vm#62 have broken
vm_introspect. This has not been noticed, because there is no CI coverage for it yet (#38). With this patch the build work locally for me again.